Pillar fixes #217
Pillar fixes #217
Conversation
|
I wonder how the error in pillar.example https://github.com/saltstack-formulas/nginx-formula/pull/217/files#diff-aef06cd118a72975a36aa9aeb06e8af6R121 make the tests successful. |
|
@daks (From information collected in saltstack-formulas/template-formula#21). This formula is using the unmaintained |
|
@myii do you mean if I find the courage and time to write those, I can submit a PR? How is it better to wait for a future refactoring of the formula (switching to versioning, to get rid of |
@daks The current testing method doesn't work at all so we don't have to wait for a future refactor to fix this. If you want to replace this with |
|
@garrettw Thanks for your patience. This PR has been (squashed and) merged! Note: As we discussed on Slack, we will get back to |
|
@myii OK. I'm also thinking of only supporting |
Squashed from: * pillar.example: an include was missing a colon * pillar.example: 2 directives not indented properly * pillar.example: added the stock log_format * pillar.example: make log path match map.jinja * pillar.example: worker_connections value from latest mainline nginx * pillar.example: fixed other uses of include * pillar.example: corrected formatting * pillar.example: corrected log_format * pillar.example: reset log_format to try another day
Squashed from: * pillar.example: an include was missing a colon * pillar.example: 2 directives not indented properly * pillar.example: added the stock log_format * pillar.example: make log path match map.jinja * pillar.example: worker_connections value from latest mainline nginx * pillar.example: fixed other uses of include * pillar.example: corrected formatting * pillar.example: corrected log_format * pillar.example: reset log_format to try another day
Just found a few issues in
pillar.exampleas I was going through it adapting it to my own needs.